Script updates #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code is organised in form of a Python package.
The plot functions have been replaced with slightly more general ones. In particular, file-like objects may be passed instead of a file path.
Minor cosmetic changes to make the code more consistent with coding standards regarding white space.
More user-friendly arguments for pie charts. Added stacked bar charts.
Whereas previously the database details were passed to the constructor of the PlotGeneration class, now a database connection is passed directly to the plot functions. As this renders the PlotGeneration class obsolete, it has been removed; its methods are standalone functions now.
The priority plot generation failed if a priority was not included in the plot data.
If no technical problem occurred during the interval considered, a pie chart with a "fake" value ("no technical downtime") is generated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've assembled the summary plot functions in a class and changed their parameters. I also put all the code in a package and provided a setup file for installing it with pip.