BF: Fix bug when CRC validation is disabled #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss_inmem; call-out to gzip doesn't appear to be any faster than python gzip library.
…reuslt in an error for streams with bytes in the CRC/size fields which match the gzip magic bytes (0x8b1f)
pauldmccarthy
force-pushed
the
bf/intermittent-crc-error
branch
from
eed9e43 to
6f1e439
Compare
pauldmccarthy
force-pushed
the
bf/intermittent-crc-error
branch
from
ffd9f8f to
1e9491b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a rare bug which would occur when CRC validation is disabled (via the
skip_crc_checkflag in Python, or theZRAN_SKIP_CRC_CHECKflag in C).When CRC validation was disabled, the logic was not moving the buffer offsets forward by 8 bytes. So when the code was searching for the next GZIP stream (in the case of concatenated streams), if the previous 8 byte stream footer (comprising the CRC and size) contained bytes which looked like a new stream (
0x1f8b) the code would incorrectly detect a new stream.I've also updated the project to use
setuptools-scmfor automatic version number management.