Add horizontal error bars and linear regression #11
Conversation
paul019
commented
Sep 4, 2023
paul019
commented
- change parser including parser logic (see README)
- update README accordingly
- update sample data accordingly
- update Measurement class to hold errors for x- and y-value
- update drawer to draw horizontal error bars
- change parser including parser logic (see README) - update README accordingly - update sample data accordingly - update Measurement class to hold errors for x- and y-value - update drawer to draw horizontal error bars
paul019
changed the title
| def get_linear_regression(self): | ||
| return do_linear_regression(self.measurements) |
There was a problem hiding this comment.
Not too sure if transformer should be worried with the linear regression. Based on what scope we have right now for the transformer
Transforms measurements into PDF coordinates based on grid configuration. Note that analyze_and_offset_measurements must be called first.
I'd say that a linear regression does not fit in this scope. Maybe construct a linear regression directly in drawer.py in line 48? Not sure if this is a good idea though.
There was a problem hiding this comment.
I find it quite fitting for the transformer. Then the drawer is only worried with drawing and the transformer is there for any data processing.
Splines
left a comment
Splines
left a comment
There was a problem hiding this comment.
some more nitpicky stuff
|
One thing to mention: we should probably somehow note (e.g. in the release notes) that this is a breaking change since the |
…aul019/pappe into feauture/horizontal-error-bars
Formerly, data and offset data was interchanged at some point. This bug fix also makes the language used clearer.
