Add useful printouts to CLI #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul019
reviewed
Sep 1, 2023
src/transformer.py
Outdated
| self.points_offset_y = points_offset_y | ||
|
|
||
| print(f'SCALING') | ||
| x_equivalent = self.grid_config['num_x_tiny_blocks_per_block'] / factor_x |
Owner
There was a problem hiding this comment.
I don't think, this formula is correct. I think, it should be x_equivalent = 1/scale_x.
Collaborator
Author
There was a problem hiding this comment.
Oh good catch, that's correct, I just fixed it.
paul019
reviewed
Sep 1, 2023
src/drawer.py
Outdated
| def _draw_vertical_axis_number(self, num_grid): | ||
| num_data = self.trafo.grid_coord_to_data_label(num_grid, Axis.VERTICAL) | ||
| label = f'{num_data:.2e}' | ||
| label = f'{num_data:.2f}' |
Owner
There was a problem hiding this comment.
I think, this isn't necessarily a good idea as the values can get very large or very small. The user should at least have the possibility to enable scientific notation.
Collaborator
Author
There was a problem hiding this comment.
You're right. I reverted this change as this has nothing to do with adding CLI print output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview
For reviewers
🙌is working fine in your console.