fix: iOS modal freeze when animationType prop is set#70
Open
dawidzawada wants to merge 1 commit intopaufau:mainfrom
Open
fix: iOS modal freeze when animationType prop is set#70dawidzawada wants to merge 1 commit intopaufau:mainfrom
dawidzawada wants to merge 1 commit intopaufau:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I've encountered an issue with modal freeze when animationType was provided, reported here: #64
I've tested the patch provided by @khanjandobariya and simplified it a little bit.
Let me know what you think!
Summary
When
animationTypeis set tofadeorslide, the modal content freezes and becomes invisible on iOS. This happens becauseprepareAnimation:is called inviewDidLoad, butanimate:is never called to transition to the visible state.Changes
initWithDelegate:ensuresinAnimation/outAnimationare never nil between init andsetAnimationType:viewDidAppear:calls[self.inAnimation animate:...]: to actually run the entrance animation after the view is on screenTesting
Tested on every modal in react-native-multiple-modals-examples using the patch below.
Simplified Patch