[RHCLOUD-43251] Adding treeview filter to DataView #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jakub007d
force-pushed
the
data-tree-view-filter
branch
3 times, most recently
from
4f47a99 to
13f5a95
Compare
Jakub007d
changed the title
Jakub007d
force-pushed
the
data-tree-view-filter
branch
2 times, most recently
from
f92d4ce to
ed2bad1
Compare
Author
|
|
Jakub007d
force-pushed
the
data-tree-view-filter
branch
from
ed2bad1 to
5c863e2
Compare
Author
|
There seems to bee an infinite loop in tests after i tried to fix the lint errors looking into it now |
Jakub007d
force-pushed
the
data-tree-view-filter
branch
from
c9fd2d8 to
536676f
Compare
Author
|
The looping should be resolved now |
|
|
||
| // Only update if there are checked items that need to be unchecked | ||
| if (currentCheckedItems.length > 0) { | ||
| const uncheckRecursive = (items: TreeViewDataItem[]): TreeViewDataItem[] => |
Collaborator
There was a problem hiding this comment.
uncheckRecursive function is defined twice in DataViewTreeFilter.tsx - once inside the useEffect hook (for syncing when value.length === 0) and once inside uncheckAllItems. Perhaps you might consider extracting it into a single reusable helper function to avoid duplicate code.
Author
There was a problem hiding this comment.
Thanks for the review i have extracted the uncheckRecursive function. Thanks for noticing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As defined in RHCLOUD-43251 adding the treeview filter to DataView