fix(core): prevent race condition on programmatic scroll#2911
Closed
brianferry wants to merge 2 commits intomainfrom
Closed
fix(core): prevent race condition on programmatic scroll#2911brianferry wants to merge 2 commits intomainfrom
brianferry wants to merge 2 commits intomainfrom
Conversation
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
✅ Commitlint tests passed!More Info{
"valid": true,
"errors": [],
"warnings": [],
"input": "fix(core): prevent race condition on programmatic scroll"
} |
This comment has been minimized.
This comment has been minimized.
Member
|
see also #2920 |
|
Contributor
bennypowers
added a commit
that referenced
this pull request
Mar 8, 2026
Fixes three bugs in ScrollSpyController: 1. Rapid clicks: setActive() now cancels previous force state via AbortController before establishing new force, preventing stale listeners from releasing force prematurely. 2. Force release timing: replaced await-first-intersection approach with scrollend event listener (+ 3s safety timeout). The old approach released force when any IO fired during smooth scroll, causing intermediate sections to steal the active state. 3. Non-contiguous sections: passedLinks are now sorted by DOM order instead of relying on Set insertion order, which was unreliable when sections had untracked content between them. Also fixes a safeguard bug where the #nextIntersection timeout set `#intersected = false` (should be `true`), which could cause an infinite rAF loop, and fixes the boundary comparison to use rootBounds.top instead of intersectionRect.top so elements exactly at the viewport top are correctly considered "passed". Closes #2911 Closes #2920 Assisted-By: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
ScrollSpyController
destinationTargetproperty for when anactiveLinkis set.destinationTargetcomes into view, it sets the#forceflag tofalseand clears thedestinationTarget.There is a race condition that is causing this issue RedHat-UX/red-hat-design-system#2425 where the
rh-jump-linkcomponent gets out of sync during a programmatic scroll event.What we're doing here is instead looking to see if we've arrived at the destinationTarget and that the destinationTarget is intersected before we continue on with the
onIoaction.Testing Instructions
This is a fix that will be felt upstream in RHDS
<rh-jump-links>Active state not consistent RedHat-UX/red-hat-design-system#2425 is not an issue for you anymore.Notes to Reviewers