Skip to content

Conversation

@patrickfust
Copy link
Owner

No description provided.

# Conflicts:
#	build.gradle
#	demos/demo-data-dictionary/gradle.properties
#	demos/demo-data-lineage/gradle.properties
#	demos/demo-erdiagram/gradle.properties
#	demos/demo-erdiagram/pom.xml
#	demos/demo-sqlscript/gradle.properties
#	documentation-generator-gradle/README.md
#	documentation-generator-maven-plugin/README.md
#	documentation-generator-maven-plugin/jreleaser.yml
#	documentation-generator-maven-plugin/pom.xml
#	generators/documentation-generator-data-dictionary/src/main/java/dk/fust/docgen/datadict/DataDictionaryGenerator.java
#	generators/documentation-generator-data-dictionary/src/test/groovy/dk/fust/docgen/datadict/DataDictionaryGeneratorSpec.groovy
#	jreleaser.yml
Copy link
Collaborator

@nynneterese nynneterese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autoresizecolumns - cifrene er svære at forholde sig til
fustCell og fustRow -> cell og row
FormatTableToExcel.toExcel metoden er meget uoverskuelig

@patrickfust
Copy link
Owner Author

autoresizecolumns - cifrene er svære at forholde sig til
fustCell og fustRow -> cell og row
FormatTableToExcel.toExcel metoden er meget uoverskuelig

Jeg har fikset fustCell og fustRow, samt forbedret FormatTableToExcel.toExcel
autoresizecolumns kræver lidt mere, så den vil jeg godt vente med indtil #10 også er reviewet, da ellers bliver tung merge-mæssigt

@nynneterese nynneterese self-requested a review December 12, 2024 10:07
@patrickfust
Copy link
Owner Author

Has moved to #12

@patrickfust patrickfust deleted the export-as-json-and-excel branch December 13, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants