Fix: handle different JWT::decode signatures#54
Conversation
|
@patrickbussmann can you approve the workflow so we can check whether the tests are still failing on this PR? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 61 63 +2
===========================================
Files 3 3
Lines 156 169 +13
===========================================
+ Hits 156 169 +13
|
|
@patrickbussmann should be okay now - workflow actions failed only on coding style, should be fixed now see https://github.com/patrickbussmann/oauth2-apple/actions/runs/8357382263 |
|
@patrickbussmann if you approve the workflow on the latest commit I bet the tests will pass this time 😉 |
|
Hi @patrickbussmann are you going to merge this PR and publish a new tag/release? |
|
@patrickbussmann Do you need help on this project? |
My focus is on other stuff at the moment. If you want to support: Feel free 👍 |
This PR provides a solution for #46 caused by different signatures of
JWT::decodefunction in the different supported versions offirebase/php-jwtThis solution has been suggested by @Kreyu in #50
If tests pass and this PR is merged then #51 , #47 and #50 can safely be closed