Add Eco-worthy 48v 100ah server rack v3 to JBD detection #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for the input but I do not see a need for this change. The battery is also detected (tests pass with your test pattern) without adding the name pattern. Was there a need for you to add it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR adds support for the Eco-Worthy 48V 100Ah Server Rack V3 battery, which uses a JBD BMS.
It includes small updates to the JBD BMS implementation along with additional test cases.
I've verified the integration end-to-end by updating the matching Bluetooth name pattern in Home Assistant BMS_BLE-HA (
manifest.json). The device is detected correctly and functions as expected; screenshots of the working device in Home Assistant are attached.Happy to adjust the implementation or add more details if needed. Thanks!