Skip to content

Enable injection of EventDispatcher #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanielBadura merged 3 commits into from
Feb 5, 2025
Merged

Enable injection of EventDispatcher #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
217ac62
Add new option subscribers
DanielBadura Feb 5, 2025
4803b4c
Intead of providing subscribers, inject the dispatcher itself
DanielBadura Feb 5, 2025
7ae57f4
Add test
DanielBadura Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/DefaultWorker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,12 @@ public static function create(
Closure $job,
array $options = [],
LoggerInterface $logger = new NullLogger(),
EventDispatcherInterface|null $eventDispatcher = null,
): self {
$eventDispatcher = new EventDispatcher();
if ($eventDispatcher === null) {
$eventDispatcher = new EventDispatcher();
}

$eventDispatcher->addSubscriber(new StopWorkerOnSigtermSignalListener($logger));

if (isset($options['runLimit'])) {
Expand Down
50 changes: 40 additions & 10 deletions tests/Unit/DefaultWorkerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
use Prophecy\Argument;
use Prophecy\PhpUnit\ProphecyTrait;
use Psr\Log\LoggerInterface;
use Symfony\Component\EventDispatcher\EventDispatcher;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;

final class DefaultWorkerTest extends TestCase
Expand All @@ -20,17 +21,17 @@ final class DefaultWorkerTest extends TestCase

public function testRunWorker(): void
{
$evenDispatcher = $this->prophesize(EventDispatcherInterface::class);
$evenDispatcher->dispatch(Argument::type(WorkerStartedEvent::class))->shouldBeCalledTimes(1);
$evenDispatcher->dispatch(Argument::type(WorkerRunningEvent::class))->shouldBeCalledTimes(1)->will(
$eventDispatcher = $this->prophesize(EventDispatcherInterface::class);
$eventDispatcher->dispatch(Argument::type(WorkerStartedEvent::class))->shouldBeCalledTimes(1);
$eventDispatcher->dispatch(Argument::type(WorkerRunningEvent::class))->shouldBeCalledTimes(1)->will(
/** @param array{WorkerRunningEvent} $args */
static function (array $args) {
$args[0]->worker->stop();

return $args[0];
},
);
$evenDispatcher->dispatch(Argument::type(WorkerStoppedEvent::class))->shouldBeCalledTimes(1);
$eventDispatcher->dispatch(Argument::type(WorkerStoppedEvent::class))->shouldBeCalledTimes(1);

$logger = $this->prophesize(LoggerInterface::class);
$logger->debug('Worker starting')->shouldBeCalledTimes(1);
Expand All @@ -40,16 +41,16 @@ static function (array $args) {
$logger->debug('Worker stopped')->shouldBeCalledTimes(1);
$logger->debug('Worker terminated')->shouldBeCalledTimes(1);

$worker = new DefaultWorker(static fn () => null, $evenDispatcher->reveal(), $logger->reveal());
$worker = new DefaultWorker(static fn () => null, $eventDispatcher->reveal(), $logger->reveal());
$worker->run(200);
}

public function testJobStopWorker(): void
{
$evenDispatcher = $this->prophesize(EventDispatcherInterface::class);
$evenDispatcher->dispatch(Argument::type(WorkerStartedEvent::class))->shouldBeCalledTimes(1);
$evenDispatcher->dispatch(Argument::type(WorkerRunningEvent::class))->shouldBeCalledTimes(1);
$evenDispatcher->dispatch(Argument::type(WorkerStoppedEvent::class))->shouldBeCalledTimes(1);
$eventDispatcher = $this->prophesize(EventDispatcherInterface::class);
$eventDispatcher->dispatch(Argument::type(WorkerStartedEvent::class))->shouldBeCalledTimes(1);
$eventDispatcher->dispatch(Argument::type(WorkerRunningEvent::class))->shouldBeCalledTimes(1);
$eventDispatcher->dispatch(Argument::type(WorkerStoppedEvent::class))->shouldBeCalledTimes(1);

$logger = $this->prophesize(LoggerInterface::class);
$logger->debug('Worker starting')->shouldBeCalledTimes(1);
Expand All @@ -63,10 +64,39 @@ public function testJobStopWorker(): void
static function ($stop): void {
$stop();
},
$evenDispatcher->reveal(),
$eventDispatcher->reveal(),
$logger->reveal(),
);

$worker->run(0);
}

public function testCustomEventDispatcher(): void
{
$listener = new class {
public int $called = 0;

public function __invoke(WorkerStartedEvent $event): void
{
$this->called++;
}
};

$eventDispatcher = new EventDispatcher();
$eventDispatcher->addListener(WorkerStartedEvent::class, $listener);

$logger = $this->prophesize(LoggerInterface::class);
$worker = DefaultWorker::create(
static function ($stop): void {
$stop();
},
[],
$logger->reveal(),
$eventDispatcher,
);

$worker->run(0);

self::assertEquals(1, $listener->called);
}
}
Loading