Skip to content

Conversation

@Camu-git
Copy link

No description provided.

@martinvonk
Copy link
Collaborator

martinvonk commented Apr 17, 2025

Hi @Camu-git,

Looks very nice!

Maybe we could look into getting the data from the pastas-data repository. That way we could use the pastas load_dataset funciton:

ds = ps.load_dataset("spek_2017")
series = ds["heads"]["B32E0031_PUTTEN"].dropna()
precname = ds["metadata"].at[series.name, "Prec [m/d]"]
evapname = ds["metadata"].at[series.name, "Evap [m/d]"]
precipitation = ds["precipitation"].loc[:, precname].multiply(1e3)
evaporation = ds["evaporation"].loc[:, evapname].multiply(1e3)

This makes it easier to also test other head series because the precipitation and evaporation series are automatically coupled to the head series via the metadata table.

@raoulcollenteur raoulcollenteur self-assigned this Jun 16, 2025
@martinvonk martinvonk removed the request for review from mbakker7 June 16, 2025 12:50
@martinvonk martinvonk requested a review from Copilot August 7, 2025 12:10

This comment was marked as resolved.

@martinvonk
Copy link
Collaborator

@Camu-git send me an email with a notebook that runs using the pastas-data and load_dataset. Maybe add that one to this pr? (and remove the old notebook if everything works.

@mbakker7
Copy link
Collaborator

I thought @Camu-git used more recent data. Are you sure the pastas-data datasets are up to date? Otherwise maybe move the updated datasets to pastas-data?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants