feat: add v5-custom-fields resource type support#77
Closed
shsketch wants to merge 1 commit intopassbolt:v5from
Closed
feat: add v5-custom-fields resource type support#77shsketch wants to merge 1 commit intopassbolt:v5from
shsketch wants to merge 1 commit intopassbolt:v5from
Conversation
- Add CustomField struct for shared custom field item representation - Add SecretDataTypeV5CustomFields and ResourceMetadataTypeV5CustomFields types - Add fallback JSON schema for v5-custom-fields - Add switch case in GetResourceFromDataWithOptions to decrypt v5-custom-fields resources - Extract password from first custom field of type "password" in secret data - Downgrade go.mod to 1.23.0 for broader compatibility
|
|
|
Hi, thanks for taking the time to contribute! We really appreciate it. We're currently working on a broader fix for this in #67, which should address this issue as part of a more comprehensive solution. With that in mind, I'll be closing this PR for now, but please don't hesitate to get involved in #67 if you'd like to help shape the direction there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CustomFieldstruct for shared custom field item representation (used in both metadata and secret data)SecretDataTypeV5CustomFieldsandResourceMetadataTypeV5CustomFieldstypes matching the Passbolt v5.3+ schemav5-custom-fieldsinResourceSchemasv5-custom-fieldscase inGetResourceFromDataWithOptionsto decrypt metadata and extract password from the first custom field of type"password"Context
Passbolt v5.3+ introduced the
v5-custom-fieldsresource type (slug:v5-custom-fields). Without this patch, any resource using this type causesGetResource/GetResourceFromDatato returnErrUnsupportedResourceType.Test plan
v5-custom-fieldsresources can be retrieved viaGetResource