PB-49603 - Go-cli re-enable staticcheck rules#75
Merged
speatzle merged 2 commits intopassbolt:v5from Mar 9, 2026
Merged
Conversation
|
|
Signed-off-by: Cédric HERZOG <cedric.herzog@passbolt.com>
cedricherzog-passbolt
force-pushed
the
feature/PB-49603_Go-cli-re-enable-staticcheck-rules
branch
from
c3c53f0 to
081261c
Compare
… error handling Signed-off-by: Cédric HERZOG <cedric.herzog@passbolt.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix all staticcheck lint warnings across go-passbolt (SDK) and go-passbolt-cli (CLI). After this change, make lint passes cleanly with zero warnings.
Changes include:
Lowercase error strings to follow Go conventions (ST1005)
Add missing package doc comments (ST1000)
Fix malformed doc comments (ST1021/ST1020/ST1022/ST1023)
Rename identifiers to follow Go naming conventions (ST1003)
Replace deprecated API calls (SA1019)
Simplify boolean comparisons (S1002)
Fix potential nil pointer dereference in tests (SA5011)
Remove unused code and assignments (U1000, SA4006)
Remove redundant break statements (S1023)
Breaking changes:
Renamed types and functions to follow Go conventions (Json → JSON, Id → ID, Http → HTTP):