PB-50128 - Go-cli : Fix release failure#125
Merged
speatzle merged 1 commit intopassbolt:mainfrom Mar 17, 2026
Merged
Conversation
Signed-off-by: Cédric HERZOG <cedric.herzog@passbolt.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failure happens when the release was published, triggering homebrew.yml.
Looking at
homebrew.yml:It runs
goreleaser release --skip=publish --skip=announce --skip=validateThis still runs the nfpm step (deb/rpm packaging), which requires the completion files
But there's no "Generate Man and Completions" step in this workflow, so the completion/ directory doesn't exist at all
The hardcoded absolute paths make it worse, but even with relative paths it would fail because the files simply aren't generated
Our fix:
Add --skip=nfpm + Go version bump
Signed-off-by: Cédric HERZOG cedric.herzog@passbolt.com