This repository was archived by the owner on Apr 17, 2024. It is now read-only.
Allow file reading in the middle of request body#245
Open
cww0614 wants to merge 1 commit intopashky:masterfrom
Open
Allow file reading in the middle of request body#245cww0614 wants to merge 1 commit intopashky:masterfrom
cww0614 wants to merge 1 commit intopashky:masterfrom
Conversation
|
LGTM! And nice 😄 |
|
I tried this in my branch but it does not seem to work. The error I see is a cryptic |
Author
Can you give an example that will cause this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMHO the regular expression to match the pattern is strict enough that in few cases will this collide with real body contents, and this enables more intuitive body construction, especially when uploading files with
multipart/form-data. Futhermore, this should also allow variable substitution in file paths.