Check Keyboard Source before Gamepad Source for keyEvent handling

[tastelessjolt]

Upstream PR: https://github.com/chrisd1100/libmatoya/pull/120

According to InputDevice:

A multi-function keyboard may compose the capabilities of a standard keyboard together with a track pad mouse or other pointing device

When handling keyEvent from such device, between SOURCE_KEYBOARD and [SOURCE_GAMEPAD, SOURCE_JOYSTICK, SOURCE_DPAD], it might be better to prefer SOURCE_KEYBOARD handling.

There is a issue in Parsec, on Samsung Galaxy Tab S8/S9 with Book Cover Keyboard, the keyEvents from this keyboard have both SOURCE_KEYBOARD and SOURCE_DPAD sources. But since the existing code handles these keyEvents as Gamepad event, normal keyboard presses don't do anything.

This change adds a SOURCE_KEYBOARD check before the Gamepad check so that Keyboard handling is preferred over Gamepad handling in multi source devices.

[FlexWasTaken]

Did you guys release this fix? (My book cover's keyboard does not work on latest version of Parsec | Galaxy Tab S8 ) Also, does this patch fix trackpad issues? (Touch click and gestures)

[tastelessjolt]

Did you guys release this fix? (My book cover's keyboard does not work on latest version of Parsec | Galaxy Tab S8 ) Also, does this patch fix trackpad issues? (Touch click and gestures)

I don't think so it is merged into a release.
Also, I'm not part of the Parsec Team but just a user who submitted this patch.
And for your second question, I don't think these changes would fix anything on the trackpad issues.

[FlexWasTaken]

If parsec devs are checking this, scrolling gesture (2 fingers goes up and down) is working but not the way expected. It moves the cursor, but not scrolling, also after releasing the fingers, Parsec's cursor is returning to original position.
It detects that I'm not moving the cursor with my one finger, but the way how it's implementing 2 finger is kinda different, also, if I slide trackpad with my 2 fingers and Parsec's cursor is on text, it changes cursor type