runs matoya tests in CI (several were broken, because nobody ever runs them) #115
Conversation
curious if it's possible to run matoya tests in CI
bmcnett
added
the
1. Coding
windows won't even nmake yet
this test may have not been working for a few years, now
… valid condition) this test shouldn't fail if sleep took longer than expected (that's a valid condition)
just a random guess for why this is failing for linux / mac
…n error until i can figure out why it's failing, i can have it fail without an error
derpity derp
more derping
on push or label-add, it tests if 'Test Matoya' flag is set
bmcnett
added
Test Matoya
wonder if this works
need steps, apparently
…s for no good reason these tests seem to hit rate limiters on a website, and fail sometimes for no good reason
printing messages in github's preferred format
tests are now deterministic (except those for MTY_*Random*)
let's use a format github likes
a little simpler
added a test that fails if the recent JSON fix is absent
can this be removed?
can this be removed, too?
environment variable "seed" should be "MATOYA_TEST_SEED"
bmcnett
added
the
2. Review requested
|
Doesn't look like tests are running, are they supposed to before we can review? |
|
This work should IMHO be delayed until our matoya fork is merged into the Parsec repo. At that point, setting up MTY tests to run in CI should be immune to these weird CI oddities that Julien might be hinting at. Moved label to L1 in light of this, but if you disagree, feel free to respond and bring the label back to L2. |
dvijayak
added
1. Coding
bmcnett
added
Test Matoya
we no longer check glslang into our repo
they were running before, and they're running now |
yeah, that seems reasonable. but it's currently unclear when we're going to get to merging libmatoya into the parsec repo.. |
bmcnett
changed the title
we plan to merge matoya into the parsec repo, at which point it would be irresponsible to not run matoya's tests as a part of parsec's tests in CI.
matoya has never had CI, and so only discretion stopped us from merging broken code into the stable branch. matoya has tests, but since nobody ran them for years, they rotted a little. this CI brings the tests back up to date, and begins putting them in a form more suitable for running alongside parsec tests in CI in the parsec repo.