Skip to content

Windows: Fix error handling for CreateRemoteThread() #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rafaeldelucena merged 3 commits into from
Jun 5, 2025
Merged

Windows: Fix error handling for CreateRemoteThread() #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4778912
CI: Update MacOS 12 job to MacOS 13
ubruhin Mar 19, 2025
a91dba6
Merge pull request #13 from LibrePCB/fix-ci
ubruhin Mar 19, 2025
130280f
Windows: Fix error handling for CreateRemoteThread()
ubruhin Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ jobs:
matrix:
include:
# Note: Nosetest doesn't work anymore with recent Python versions!
- {qt: "5", runner: "macos-12", nosetests: 0}
- {qt: "5", runner: "macos-13", nosetests: 0}
- {qt: "6", runner: "macos-14", nosetests: 0}
env:
FUNQ_QT_MAJOR_VERSION: "${{ matrix.qt }}"
Expand Down
7 changes: 6 additions & 1 deletion server/funq_server/runner_win.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,8 +215,13 @@ def _raise_windows_error(self, function_name, return_value):
"""
last_error = ctypes.get_last_error()
win_error = ctypes.WinError(last_error)
try:
# Try formatting as hex.
return_value = "{} (0x{:X})".format(return_value, return_value)
except TypeError:
pass
message = "Failed to inject DLL! "
message += "{} returned 0x{:X}. ".format(function_name, return_value)
message += "{} returned {}. ".format(function_name, return_value)
message += "The last error is 0x{:X} ({}). ".format(
last_error, str(win_error))
message += "Maybe x86/x64 mismatch between python.exe and Qt DLLs?"
Expand Down
Loading