Open
Conversation
Test Results106 tests 106 ✅ 1s ⏱️ Results for commit 248aa3d. |
youngh0
requested changes
Mar 9, 2024
Contributor
youngh0
left a comment
youngh0
left a comment
There was a problem hiding this comment.
고생하셨습니다~ 코멘트 남겼으니 확인 부탁드려요 ㅎ
| @GetMapping("/announcements") | ||
| public ResponseEntity<Page<Announcement>> findAnnouncements(@RequestParam String type, Pageable pageable) { | ||
| AnnouncementType announcementType = AnnouncementType.findType(type); | ||
| Page<Announcement> announcements = announcementRepository.findAllByAnnouncementType(announcementType, pageable); |
Contributor
There was a problem hiding this comment.
이렇게 응답이 나가면 정적파일이 아니라 파일의 filename 이 담긴 json 이 나가게 되는거 아닌가요?? html 파일이 나가나요??
|
|
||
| public interface AnnouncementRepository extends JpaRepository<Announcement, Long> { | ||
|
|
||
| Page<Announcement> findAllByAnnouncementType(AnnouncementType announcementType, Pageable pageable); |
Contributor
There was a problem hiding this comment.
Page 로 하신 이유가 있나요?? 제가 Page 를 잘몰라서..
This2sho
reviewed
Mar 10, 2024
Contributor
This2sho
left a comment
This2sho
left a comment
There was a problem hiding this comment.
공지사항과 이벤트 모두 어차피 정적페이지를 조회하는거라 하나로 묶어도 괜찮을 듯 합니다.
어떻게 생각하시는지요 ?
좋습니다.
그리고 html파일은 서버에서 정적파일로 갖고있는게 나을 것 같습니다. 본문을 디비에 저장하는것보다요.
어떻게 생각하시는지요 ?
좋습니다. 근데 그러면 저희가 엔티티로 관리할 필요가 없을거 같은데 어떻게 생각하시나여?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👍관련 이슈
🤔세부 내용
🫵리뷰 중점사항
공지사항과 이벤트 모두 어차피 정적페이지를 조회하는거라 하나로 묶어도 괜찮을 듯 합니다.
어떻게 생각하시는지요 ?
그리고 html파일은 서버에서 정적파일로 갖고있는게 나을 것 같습니다. 본문을 디비에 저장하는것보다요.
어떻게 생각하시는지요 ?