This repository was archived by the owner on Jul 28, 2021. It is now read-only.
Don't show document-related menu items until document loaded#9
Open
Lesik wants to merge 4 commits intoparide:develfrom
Open
Don't show document-related menu items until document loaded#9Lesik wants to merge 4 commits intoparide:develfrom
Lesik wants to merge 4 commits intoparide:develfrom
Conversation
Owner
|
Thanks @Lesik. Let's see if @Tommy-Geenexus chimes in, otherwise I'll merge this as it is, if you agree. |
|
Sorry for the delay. var renderTask = page.render(renderContext); I can't contribute code atm, as i'm very busy, but i hope this helps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed with @Tommy-Geenexus in #7, this PR implements an onDocumentLoaded callback that enables document-related menu items such as printing.
One thing I'm not 100% happy with is that the callback is run a lot earlier than when the whole page is actually rendered. Maybe @Tommy-Geenexus can help?