Skip to content

feat: replace aws creds with oidc #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kpplis merged 2 commits into from
Sep 8, 2025
Merged

feat: replace aws creds with oidc #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b26bbd3
start over
kpplis Sep 8, 2025
481978d
add role
kpplis Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/workflows/build-and-push-image-to-ecr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,15 @@ on:
default: ""
type: string
secrets:
AWS_ACCESS_KEY_ID:
required: true
AWS_SECRET_ACCESS_KEY:
AWS_ROLE_TO_ASSUME:
required: true
description: AWS OIDC role for GitHub to assume

jobs:
build-and-push-image-to-ecr:
permissions:
id-token: write
contents: read
runs-on: ubuntu-latest
steps:
- name: Checkout current git repository
Expand All @@ -46,9 +48,8 @@ jobs:
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v2
with:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
aws-region: eu-central-1
role-to-assume: ${{ secrets.AWS_ROLE_TO_ASSUME }}
- name: Create ECR repository if it doesn't exist
run: |
aws ecr describe-repositories --repository-names ${{ inputs.APPLICATION_NAME }} || \
Expand Down
12 changes: 8 additions & 4 deletions .github/workflows/build-image.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ env:
jobs:
build-ecr-single:
if: inputs.imageTargets == ''
permissions:
id-token: write
contents: read
environment: ${{ github.event.deployment.payload.env }}
runs-on: ${{ inputs.runner }}
steps:
Expand All @@ -87,9 +90,8 @@ jobs:
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v2
with:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
aws-region: eu-central-1
role-to-assume: ${{ secrets.AWS_ROLE_TO_ASSUME }}
- name: Create ECR repository if it doesn't exist
run: |
aws ecr describe-repositories --repository-names ${{ github.event.deployment.payload.name }} || \
Expand Down Expand Up @@ -135,6 +137,9 @@ jobs:

build-ecr-matrix:
if: inputs.imageTargets != ''
permissions:
id-token: write
contents: read
environment: ${{ github.event.deployment.payload.env }}
runs-on: ${{ inputs.runner }}
strategy:
Expand All @@ -161,9 +166,8 @@ jobs:
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v2
with:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
aws-region: eu-central-1
role-to-assume: ${{ secrets.AWS_ROLE_TO_ASSUME }}
- name: Create ${{ matrix.containerfile_targets }} ECR repository if it doesn't exist
run: |
aws ecr describe-repositories --repository-names ${{ github.event.deployment.payload.name }}-${{ matrix.containerfile_targets }} || \
Expand Down
10 changes: 2 additions & 8 deletions .github/workflows/kubernetes.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,15 +120,9 @@ on:
sentryAuthToken:
required: false
description: Authentication token for Sentry
AWS_ACCESS_KEY_ID:
AWS_ROLE_TO_ASSUME:
required: true
description: Access key ID for AWS credentials
AWS_SECRET_ACCESS_KEY:
required: true
description: Secet for AWS access key ID
AWS_ACCOUNT_ID:
required: true
description: AWS Account ID
description: AWS OIDC role for GitHub to assume

jobs:
initialize:
Expand Down