Skip to content

feat: scan images#30

Merged
kpplis merged 14 commits intomainfrom
feat/scanning-images
Jan 7, 2025
Merged

feat: scan images#30
kpplis merged 14 commits intomainfrom
feat/scanning-images

Conversation

@kpplis
Copy link
Contributor

@kpplis kpplis commented Dec 18, 2024

  • Fix bug with build failing if list of targets was not provided
  • Implement image scanning before the push
  • Split image build and push steps into 2
  • Split image build and push jobs into 4

@github-actions github-actions bot added the ci label Dec 18, 2024
@kpplis kpplis marked this pull request as ready for review December 20, 2024 13:10
@kpplis kpplis requested review from a team and andibeuge December 20, 2024 13:10
@andibeuge andibeuge self-requested a review December 20, 2024 14:47
Copy link
Contributor

@andibeuge andibeuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is something not working correctly with the env variable passing https://github.com/parcelLab/flask-blueprint-app/actions/runs/12433405183/job/34714875567

@andibeuge
Copy link
Contributor

I think there is something not working correctly with the env variable passing https://github.com/parcelLab/flask-blueprint-app/actions/runs/12433405183/job/34714875567

it seems to be related with the triggered deployment pipeline missing the values to populate

@andibeuge
Copy link
Contributor

I think there is something not working correctly with the env variable passing https://github.com/parcelLab/flask-blueprint-app/actions/runs/12433405183/job/34714875567

it seems to be related with the triggered deployment pipeline missing the values to populate

seems to relate to missing "production" env in plconfig.yaml

@andibeuge andibeuge self-requested a review December 20, 2024 15:38
Copy link
Contributor

@andibeuge andibeuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a check if the value for env from the deployment event is set in this pipeline

@kpplis kpplis requested a review from andibeuge January 7, 2025 09:07
@kpplis kpplis merged commit 5d92177 into main Jan 7, 2025
5 checks passed
@kpplis kpplis deleted the feat/scanning-images branch January 7, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants