Supports explicit endpoint configuration

[jkassemi]

config block all the things

[parasquid]

I think it would be better if when config.endpoint is blank, it will auto detect the environment and auto-fill the url accordingly. In other words, use config.endpoint when available otherwise fallback to original behavior.

Why do you need to only allow explicit endpoint configuration? :)

[jkassemi]

Howdy @parasquid!

The changes support explicit endpoint configuration, but they do fall back to implicit by default:

require 'helper'

describe Namecheap::Api do
  before { set_dummy_config }

  it 'uses sandbox for development environments' do
    stub_const('Rails', double(env: 'development'))
    load File.join(File.dirname(__FILE__), '../../lib/namecheap/api.rb')

    expect(HTTParty).to receive(:get).with(Namecheap::Api::SANDBOX, anything())
    subject.request('get', 'world', {})
  end

  it 'uses sandbox for unspecified environment' do
    load File.join(File.dirname(__FILE__), '../../lib/namecheap/api.rb')
    expect(HTTParty).to receive(:get).with(Namecheap::Api::SANDBOX, anything())
    subject.request('get', 'world', {})
  end

  it 'uses production for production environments' do
    stub_const('Rails', double(env: 'production'))
    load File.join(File.dirname(__FILE__), '../../lib/namecheap/api.rb')
    expect(HTTParty).to receive(:get).with(Namecheap::Api::PRODUCTION, anything())
    subject.request('get', 'world', {})
  end

  it 'directs the endpoint where specified' do
    Namecheap.config.endpoint = 'http://example.com'
    load File.join(File.dirname(__FILE__), '../../lib/namecheap/api.rb')
    expect(HTTParty).to receive(:get).with('http://example.com', anything())
    subject.request('get', 'world', {})
    Namecheap.config.endpoint = nil
  end
end

The above aren't included because I'm not a fan of the 'load' pattern I had to use.

I generally prefer the explicit definition on a feature by feature basis (Twelve-Factor App Config and dotenv), but in this case specifically I'm running Rails in production mode on a staging server and would still like that system to call out to Namecheap's sandbox ;)

It could make testing this easier if we'd refactor Namecheap::Api{#init_args, SANDBOX, PRODUCTION, ENVIRONMENT, ENDPOINT} into Namecheap::Config and avoid configuration state on load. What do you think?

[parasquid]

Sounds cool, I was just concerned that this pr will be a breaking change that will affect backwards compatibility.

I also agree with you, so how about we bump the major version number with this one? And probably temporarily maintain two versions and back port new features.