Make product id optional #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support to only spread the producst when they are present as well
solocommand
requested changes
Oct 20, 2025
| }); | ||
| }), | ||
| }), | ||
| Emails: [{ EmailAddress: email }], |
Member
There was a problem hiding this comment.
Update the above section when the product map is initialized to include the product id only if one is set. L374
- const productMap = new Map([[input.productId, true]]);
+ const productMap = new Map([...(input.productId ? [input.productId, true] : [])]);
| const promoCode = input.promoCode ? input.promoCode.trim() : null; | ||
| if (promoCode && promoCode.length > 50) throw new UserInputError('The promo code must be 50 characters or fewer.'); | ||
| const productMap = new Map([[input.productId, true]]); | ||
| const productMap = new Map([...(input.productId ? [input.productId, true] : [])]); |
Member
There was a problem hiding this comment.
The spread is redundant, and could be
const productMap = new Map(input.productId ? [input.productId, true] : []);But ultimately doesn't matter :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to only spread the product when they are present as well
example send to the api and our request to omeda. It was a first name of Brian
Update within omeda without sending productId
