Optimizations and bug fix#3
Open
DickyT wants to merge 1 commit intoparamaggarwal:masterfrom
DickyT:master
Open
Optimizations and bug fix#3DickyT wants to merge 1 commit intoparamaggarwal:masterfrom DickyT:master
DickyT wants to merge 1 commit intoparamaggarwal:masterfrom
DickyT:master
Conversation
Owner
|
Looks good @DickyT. Just two tiny comments, and we can merge it in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I noticed that inside the
addListener, if someone trying to listen to an event which is already listened before, which will causeRNTGlobalEventEmitter.addObserver(eventName);run one more time, which is unnecessary to register an native listener at NSNotificationCenter.Whats more, I added
removeListenderByIdmethod, because sometimes to deal with scope issues, you need to passing a closure / code block to theaddListener, which makesremoveListenerharder. WithremoveListenderById, you only need to passing the event name and the reference ID, which can get fromaddListener.