Open
Conversation
Signed-off-by: GopherJ <alex_cj96@foxmail.com>
Signed-off-by: GopherJ <alex_cj96@foxmail.com>
Signed-off-by: GopherJ <alex_cj96@foxmail.com>
i5possible
reviewed
Feb 1, 2023
Co-authored-by: Hong Liang <lianghongbuaa@gmail.com>
Signed-off-by: GopherJ <alex_cj96@foxmail.com>
0x8f701
commented
Feb 1, 2023
0x8f701
commented
Feb 1, 2023
0x8f701
commented
Feb 1, 2023
0x8f701
commented
Feb 1, 2023
0x8f701
commented
Feb 1, 2023
contracts/protocol/tokenization/libraries/MintableERC721Logic.sol
Outdated
Show resolved
Hide resolved
0x8f701
commented
Feb 1, 2023
contracts/protocol/tokenization/libraries/MintableERC721Logic.sol
Outdated
Show resolved
Hide resolved
0x8f701
commented
Feb 1, 2023
0x8f701
commented
Feb 1, 2023
contracts/protocol/tokenization/libraries/MintableERC721Logic.sol
Outdated
Show resolved
Hide resolved
i5possible
reviewed
Feb 1, 2023
Signed-off-by: GopherJ <alex_cj96@foxmail.com>
Codecov Report
@@ Coverage Diff @@
## main #326 +/- ##
==========================================
+ Coverage 75.24% 75.80% +0.55%
==========================================
Files 83 83
Lines 3826 3918 +92
Branches 714 737 +23
==========================================
+ Hits 2879 2970 +91
+ Misses 571 560 -11
- Partials 376 388 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: GopherJ <alex_cj96@foxmail.com>
Signed-off-by: GopherJ <alex_cj96@foxmail.com>
Signed-off-by: GopherJ <alex_cj96@foxmail.com>
Signed-off-by: GopherJ <alex_cj96@foxmail.com>
Signed-off-by: GopherJ <alex_cj96@foxmail.com>
Signed-off-by: GopherJ <alex_cj96@foxmail.com>
Signed-off-by: GopherJ <alex_cj96@foxmail.com>
Signed-off-by: GopherJ <alex_cj96@foxmail.com>
Signed-off-by: GopherJ <alex_cj96@foxmail.com>
0x8f701
commented
Feb 2, 2023
| { | ||
| return ( | ||
| _ERC721Data.userState[account].balance, | ||
| _ERC721Data.userState[account].atomicBalance, |
Contributor
Author
There was a problem hiding this comment.
we should optimize the gas cost here because we are not using all these anymore in GenericLogic
0x8f701
commented
Feb 2, 2023
Signed-off-by: GopherJ <alex_cj96@foxmail.com>
0x8f701
commented
Feb 2, 2023
| uint64 balanceLimit; | ||
| mapping(uint256 => bool) isUsedAsCollateral; | ||
| mapping(uint256 => DataTypes.Auction) auctions; | ||
| address underlyingAsset; |
Contributor
Author
There was a problem hiding this comment.
this should still take the same slot 67
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: GopherJ alex_cj96@foxmail.com
Security Checklist
Make sure to think about each of these exploits in this PR.