This repository was archived by the owner on Nov 22, 2021. It is now read-only.
Issue #71: Fixed fallback emojis on Selector class #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parafoxia
suggested changes
Oct 7, 2020
Owner
parafoxia
left a comment
parafoxia
left a comment
There was a problem hiding this comment.
Overall, good PR! Changes mainly focussed around increasing consistency across Solaris' code base.
Co-authored-by: parafoxia <43846948+parafoxia@users.noreply.github.com>
Co-authored-by: parafoxia <43846948+parafoxia@users.noreply.github.com>
Co-authored-by: parafoxia <43846948+parafoxia@users.noreply.github.com>
Co-authored-by: parafoxia <43846948+parafoxia@users.noreply.github.com>
Co-authored-by: parafoxia <43846948+parafoxia@users.noreply.github.com>
Co-authored-by: parafoxia <43846948+parafoxia@users.noreply.github.com>
parafoxia
approved these changes
Oct 9, 2020
Owner
parafoxia
left a comment
parafoxia
left a comment
There was a problem hiding this comment.
Looks good. I'll wait until I'm ready commit other stuff for the 1.2.3 release, but the changes should be good. Thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Selectorclass usedemoji.namebut fallback emojis are strings themselves, and callingnameonstringthrows an error. Replacedemoji.namewith aget_emoji_namefunction that handles string emojis.