fix: Make externalClusters conditional to prevent null value in standalone mode #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated to match upstream PR cloudnative-pg#760 which fixes the same issue: - Moved externalClusters field inside conditional in template - Reverted cluster.yaml to unconditional include - Preserved ParadeDB-specific custom externalClusters feature This minimizes future rebase conflicts with upstream while maintaining backward compatibility with ParadeDB's custom external cluster configuration. Related: cloudnative-pg#760
…ment test The test was failing because paradedb/paradedb:17-v0.15.20 image does not exist on Docker Hub, causing ImagePullBackOff. Updated to use 0.15.21 which exists and is already used in the post-upgrade step.
- Updated from v0.15.20/v0.15.21 to v0.20.5 (latest release) - Fixed ImagePullBackOff error (v0.15.20 image doesn't exist) - Updated all test configs and assertions to use v0.20.5
ankitml
commented
Dec 30, 2025
charts/paradedb/test/database-management/02.4-paradedb_extension_check.yaml
Outdated
Show resolved
Hide resolved
Member
philippemnoel
left a comment
philippemnoel
left a comment
There was a problem hiding this comment.
it lgtm aside from all the extension version changes which I don't think should be there
philippemnoel
approved these changes
Dec 30, 2025
philippemnoel
pushed a commit
that referenced
this pull request
Dec 30, 2025
philippemnoel
pushed a commit
that referenced
this pull request
Dec 30, 2025
philippemnoel
pushed a commit
that referenced
this pull request
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
spec.externalClusters: Invalid value: "null"error that occurs when deploying in standalone mode with backups disabled and using strict YAML validation (server-side apply).This fix aligns with upstream CloudNativePG charts PR #760 to minimize future rebase conflicts.
Root Cause
When
mode: standaloneandbackups.enabled: false, the generated YAML ends with:externalClusters:with no content. Strict YAML parsers interpret this as
externalClusters: nullinstead of an empty array, causing CNPG operator validation to fail.Changes Made
1. Fixed
_external_clusters.tplexternalClusters:field inside conditional logic2. Updated CI Validation
--server-side --validate=strictflags tokubectl applyin deploy-cluster actionTesting
Related