Fix / improve window behaviour: restore pre-fullscreen/pre-scratch window size/position; better manage windows that start fullscreen

[jtaala]

Fixes #739, and partially fixes #638.

This PR includes improvements to window fullscreening behaviours:

1. better handle application windows that start as fullscreen windows;
2. restores window size and positions after un-fullscreening;
3. scratching a window now properly activates that window (previously is wasn't properly activated);
4. restores window size and positions after when scratching a window;

(1) is part of the fix required for #638 (the other part is an upstream issue that will be fixed in mutter with patch 3401 - which has been merged but not released yet).

These changes fix issues for me in kodi - but not the osu! issues (which requires also requires mutter fixes as mentioned above).

[jtaala]

The other option is I can move this new approach I'm working on to a new branch and release the commit you approved?

honestly sounds like a plan

Yeah, especially since this new approach might turn out to have more issues than the previous approach...

[jtaala]

@Thesola10 - do have the commit number you approved?

[Thesola10]

I had c0153754 tagged as working before pulling updates today

[jtaala]

Okay, I'm going to reset this PR branch back to that commit.

[jtaala]

Hey @Thesola10, can you pull and test the latest on this branch. A few small changes here:

• behaviour change: if you have a fullscreen window and select another tiled window (on the space) - unfullscreen the fullscreened window. This feels more natural to me and allows us to fix the following multimonitor bugs:
• remove flash of topbar spacing when moving mouse to another monitor;
• stop window position bar from showing on monitor you left when it has a fullscreen window.

[Thesola10]

feels pretty nice, fixes fullscreen issues

[Lythenas]

behaviour change: if you have a fullscreen window and select another tiled window (on the space) - unfullscreen the fullscreened window. This feels more natural to me and allows us to fix the following multimonitor bugs:

I think that could cause problems. I guess mostly with games or other things that are supposed to be always fullscreen. But let me test it a bit.

[Lythenas]

Actually immediately found some^^

Normally when this game is fullscreen and you focusing another window (on the current or other monitor) the game minimizes). You have to Alt+Tab back to it again.

With these changes after navigating to another window on the same monitor, it looks like this:

The game still shows on top of other windows but you click through it to the window that is below. You can still get back to the game via Alt+Tab. Focusing another monitor while the game is maximized still minimizes it.

This means if you don't have a second monitor you can't tab out of the game anymore.

Another game (MTG Arena) is basically the same, except it takes up the entire screen and you just click through it but can't see anything.

Another game (Warframe) does not become fullscreen again after focusing away and back to it. You have to Alt+Enter twice (once to go to windowed mode and the second time to go to fullscreen mode again). I think that is implemented by the game. This game also does not lose focus when navigating to another monitor. So focusing another window on the same monitor is the only way to tab out of the game in PaperWM.

So I'm against the last couple of commits. Games make enough problems on Linux, we should try to avoid introducing any more^^

I think I was also on commit c015375 before and that worked fine.

Regarding the topbar behavior we can probably also change that without unfullscreening a window. E.g. we could consider a space fullscreen only if the active window is fullscreen (instead of any window). In #707 I also try to fix some of these issues.

[Lythenas]

Also I noticed with the last commits navigating workspaces via Super+PageUp/Down does not complete the navigation. You are stuck in the zoomed out animation until you click a window to focus it.

Edit: Actually also the window navigation is the same. The window preview does not close until you click on a window. I saw this error in the logs. But it's not always generated:

gnome-shell[14942]: JS ERROR: TypeError: this.signals is null
                                            destroy@file:///home/ms/.local/share/gnome-shell/extensions/paperwm@paperwm.github.com/navigator.js:254:9
                                            dismissDispatcher@file:///home/ms/.local/share/gnome-shell/extensions/paperwm@paperwm.github.com/navigator.js:468:20
                                            _finish@file:///home/ms/.local/share/gnome-shell/extensions/paperwm@paperwm.github.com/navigator.js:228:26
                                            finishDispatching@file:///home/ms/.local/share/gnome-shell/extensions/paperwm@paperwm.github.com/navigator.js:454:24
                                            select@file:///home/ms/.local/share/gnome-shell/extensions/paperwm@paperwm.github.com/stackoverlay.js:211:19
                                            ClickOverlay/<@file:///home/ms/.local/share/gnome-shell/extensions/paperwm@paperwm.github.com/stackoverlay.js:131:18
                                            @resource:///org/gnome/shell/ui/init.js:21:20

[jtaala]

Actually immediately found some^^

Into the Breach!

Thanks @Lythenas for the further testing there. I've reverted the unfullscreening approach. And one of the fixes that relied on it.

Still have the small "bobble" issue, it was just a check on layout. Will see if there's something quick that can be done here to resolve that one too, otherwise will leave that one for later.

[jtaala]

Hey all, I believe I've fixed the "bobble" issue when moving mouse to another monitor when a fullscreen window is active.

Give this one a go.

[Lythenas]

Works fine now.