Problem: fy_node_compare_user does not recurse with itself #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, it recurses with fy_node_compare which, in effect, "loses" user settings. Solution: make it user the `user` flavour of the function
Contributor
Author
|
Bumping this up as this seems to be a rather important bug (incomplete comparison using user-supplied comparison methods) |
Contributor
Author
|
Any chance this can be reviewed, as it fixes a rather important bug for user-supplied comparisons? Thank you! (Ideally, together with #87) |
Contributor
Author
|
Is there any chance for this to get reviewed? It seems to be a pretty critical piece for user-supplied comparison. |
Owner
|
Will take a look, seems harmless enough |
Contributor
Author
|
Bumping this issue up. Any chance for a review? Thanks! Happy New Year :) |
Contributor
Author
|
Bumping this issue up as it is fairly critical. |
Contributor
Author
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, it recurses with fy_node_compare which, in effect, "loses" user settings.
Solution: make it user the
userflavour of the function