fix(refactor): optimize IngestActivity by reducing save queries and c… #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orrecting average time calculation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request refactors the
IngestActivityto optimize its performance and fix critical issues:Reduced Write Queries:
The number of write queries has been reduced from 2 to 1. Since this is a job that will run frequently, it's important to optimize it from the beginning to ensure better performance and scalability.
Fixed Average Time Calculation:
There was a major issue with the calculation of the average time. While it worked correctly for the first and second views, subsequent calculations were incorrect. This refactoring resolves the issue, ensuring the average time is calculated accurately.
Integration with Other PR:
This correction complements the improvements made in the
IngestActivityTestsubmitted in a separate pull request. Together, these changes ensure theIngestActivityworks reliably and is thoroughly tested.Notes for Reviewers
This is a significant refactoring, and it’s recommended to review the code with caution, as the changes were implemented quickly. Please double-check the logic to ensure everything works as intended.