Add config option to allow running insecure content#9
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new XML config option to enable WebView2’s --allow-running-insecure-content switch, intended to unblock demos that need to access insecure (e.g., HTTP / ws://) resources from the embedded WebView.
Changes:
- Add
<allowrunninginsecurecontent/>config parsing and apply the corresponding WebView2 browser argument. - Introduce an
AddBrowserArgumenthelper to append multiple WebView2 command-line switches without overwriting previous ones. - Document the new config option in
readme.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| readme.md | Documents the new <allowrunninginsecurecontent/> config option and links it to the WebView2 flag. |
| MainWindow.xaml.cs | Parses the new XML tag and appends --allow-running-insecure-content to WebView2 additional browser arguments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
URL: https://learn.microsoft.com/en-us/microsoft-edge/webview2/concepts/webview-features-flags?tabs=dotnetcsharp allow-running-insecure-content: Enables insecure content in Cast Web Runtime. This flag unblocks MSPs that serve content from HTTP sources. This is for use cases where local WebDemoExe tries to access unsecured (local) connections, for example, light server protocol at Instanssi demoparty
mrautio
force-pushed
the
feature/allow-insecure-sockets
branch
from
8e9ca79 to
5c3fc7f
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add configuration option
<allowrunninginsecurecontent/>to allow running insecure content.URL: https://learn.microsoft.com/en-us/microsoft-edge/webview2/concepts/webview-features-flags?tabs=dotnetcsharp
allow-running-insecure-content: Enables insecure content in Cast Web Runtime. This flag unblocks MSPs that serve content from HTTP sources.
This is for use cases where local WebDemoExe tries to access unsecured connections, for example, light server protocol at Instanssi demoparty