New default domain, small cleanup, improve build-time validation#8
Merged
New default domain, small cleanup, improve build-time validation#8
Conversation
mrautio
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR updates the virtual host domain configuration and enhances the project's build quality controls. The change from appassets.example to webdemoexe.localhost provides a more meaningful domain name, while the project configuration improvements add comprehensive code analysis and build validation.
- Changed default virtual host domain from
appassets.exampletowebdemoexe.localhost - Added comprehensive build-time validation with warnings as errors and code analyzers
- Cleaned up project file by removing unused content references and updating package versions
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| readme.md | Added build status badge and documented the new domain configuration option |
| WebDemoExe.csproj | Enhanced build validation settings, updated packages, and removed unused content items |
| MainWindow.xaml.cs | Implemented configurable domain support with new default domain |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
webdemoexe.localhostinstead ofappassets.example