Utilize Protobuf for enforcing Schema Synchronization #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewQuijano
force-pushed
the
one-db
branch
from
9f9c044 to
b1cff63
Compare
github-actions
bot
added
Lava-Core
AndrewQuijano
force-pushed
the
one-db
branch
from
94e4d63 to
9386a62
Compare
AndrewQuijano
force-pushed
the
one-db
branch
from
9386a62 to
10b5ae2
Compare
github-actions
bot
added
the
dependencies
AndrewQuijano
changed the title
AndrewQuijano
force-pushed
the
one-db
branch
from
6a63596 to
5978ee5
Compare
AndrewQuijano
force-pushed
the
one-db
branch
6 times, most recently
from
37b836f to
6cd2b9e
Compare
AndrewQuijano
force-pushed
the
one-db
branch
2 times, most recently
from
26b98cb to
6faa887
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
This PR completes the following tasks:
Utilize Protobuf to generate some of the C++/Python database classes. Use this to confirm the table names and fields match to protobuf to avoid database drift.
a) For C++ there is a function called
__enforce_proto, this confirms the fields match what is on protobuf and on the struct. It also confirms the name of the Struct and Protobuf match, e. g. it is called Loc and Loc.b) For Python a test case was added to confirm it matches with protobuf too.
Other minor fixes, such as:
a. changing the argument to just be 'x86_64', not 'panda-system-x86_64'
b. Updating the Hypercall to be multi-arch, prep for ARM
c. We use the new SQL Alchemy version of Composite, not the hack used.
Test plan
Since I am only changing for the database is built, the same CI/CD should pass.
...
Closing issues
...