Fix mid-transaction connection switch issue #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viralpraxis
force-pushed
the
yk/fix-mid-transaction-connection-switch-issue
branch
from
5198bc3 to
34bb06b
Compare
Resolves palkan#83 Apparently, there's [another issue on the Rails side](rails/rails#55306) so Isolator's failure is just a symptom. Still, I think it makes sense to check `connection_id` explicitly and skip threshold change in case of connection switching, since it's an implicit invariant.
viralpraxis
force-pushed
the
yk/fix-mid-transaction-connection-switch-issue
branch
from
34bb06b to
85599c4
Compare
|
@viralpraxis do you have plans to finish this? I think we experience the same issue. |
Collaborator
Author
Yeah, I’m coming back from my vacation in a week and I’m planning to revisit this one. As far as I remember current patch does not solve the issue so there is some extra investigation to do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #83
Apparently, there's another issue on the Rails side so Isolator's failure is just a symptom. Still, I think it makes sense to check
connection_idexplicitly and skip threshold change in case of connection switching, since it's an implicit invariant.Checklist