Fix incomplete toBuilder implementations and add tests

[Marcono1234]

Description

Fixes #341

• For JavaFile it was not copying staticImports
• For TypeSpec it was not copying recordConstructor
• For TypeSpec it was accumulating additional elements in originatingElements from nested types for every toBuilder().build() cycle
• For ParameterSpec it was not copying javadoc

[palantirtech]

Thanks for your interest in palantir/javapoet, @Marcono1234! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

[Marcono1234]

Note: Unless you have a policy to create a release after every change, I would not mind if you wait a bit. I might create another PR as well.

(And these fixes are not that critical that they require immediate releases?)

[carterkozak]

Nice, this is a sneaky one

[Marcono1234]

Side note: The FieldSpec and TypeSpec builder currently have a varargs variant only (and no Iterable one), I am a bit afraid the same issue could re-appear there again in case an Iterable overload is added as well.

[carterkozak]

Would you like to add the Iterable overload for symmetry in this change?

[Marcono1234]

I have included that in #87, I hope that is ok. I will probably revert this addModifiers change here.

[carterkozak]

Note: Unless you have a policy to create a release after every change, I would not mind if you wait a bit. I might create another PR as well.

Our robots make releases trivial -- we generally release from all human-authored commits, releasing one change doesn't make it any less likely we'll cut a release on another PR :-]

[Marcono1234]

Our robots make releases trivial -- we generally release from all human-authored commits, releasing one change doesn't make it any less likely we'll cut a release on another PR :-]

Yeah, my concern wasn't so much how easy it is to make a release 😅
Rather if it is really needed. Technically storage on Maven Central is unlimited and free but maybe it would still make sense to be a bit conservative? Also, multiple releases in quick succession might cause overhead for users, especially if they have Dependabot or similar configured (and run it daily). But not sure how big these issues are or if they are even real issues at all, and in the end it is of course your decision.

I just wanted to express that I am not urgently waiting for these changes to be released.

This change looks good, please sign the cla

[carterkozak]

This change looks good, thanks! Please complete the cla: #85 (comment)

[Marcono1234]

Currently still waiting for an answer to my questions regarding the CLA, see #84 (comment).

[stale]

This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days.

[Marcono1234]

Have created #341 now to track that this issue is still unresolved.