Excavator: Switch to JUnit 5 to parallelize tests and speed up CI#156
Merged
bulldozer-bot[bot] merged 5 commits intodevelopfrom Jul 24, 2025
Merged
Excavator: Switch to JUnit 5 to parallelize tests and speed up CI#156bulldozer-bot[bot] merged 5 commits intodevelopfrom
bulldozer-bot[bot] merged 5 commits intodevelopfrom
Conversation
cb78578 to
98687c0
Compare
98687c0 to
560495e
Compare
560495e to
39294ca
Compare
39294ca to
64decf2
Compare
c20776f to
9e73c22
Compare
9e73c22 to
e9b5810
Compare
e9b5810 to
d846805
Compare
d846805 to
9e0ddb6
Compare
9e0ddb6 to
f94e3bc
Compare
f94e3bc to
440999a
Compare
440999a to
5e6b42f
Compare
5e6b42f to
f100d76
Compare
f100d76 to
07eda51
Compare
07eda51 to
11ee87e
Compare
11ee87e to
3eef55d
Compare
3eef55d to
02431c2
Compare
02431c2 to
f4328e2
Compare
|
This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days. |
f4328e2 to
bcd1b03
Compare
bcd1b03 to
90ac530
Compare
90ac530 to
2bdb26a
Compare
|
As discussed internally, There were three options:
Compiler.javac()
.withProcessors(new AbstractProcessor() {
@Override
public boolean process(Set<? extends TypeElement> annotations, RoundEnvironment roundEnv) {
test.accept(processingEnv.getElementUtils());
return false;
}
})
.compile(DUMMY)
We decided to go with that third option for now and disable the excavator once this PR merges |
pkoenig10
reviewed
Jul 24, 2025
Comment on lines
44
to
46
| Assertions.assertThrows(NullPointerException.class, () -> { | ||
| TypeName.BOOLEAN.annotated((AnnotationSpec[]) null); | ||
| }); |
Member
There was a problem hiding this comment.
Use AssertJ
Suggested change
| Assertions.assertThrows(NullPointerException.class, () -> { | |
| TypeName.BOOLEAN.annotated((AnnotationSpec[]) null); | |
| }); | |
| assertThatThrownBy(() -> { | |
| TypeName.BOOLEAN.annotated((AnnotationSpec[]) null); | |
| }) | |
| .isInstanceOf(NullPointerException.class); |
There was a problem hiding this comment.
Indeed - this was updated by the excacvator and I didn't notice. I'll push a change
pkoenig10
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
excavator is a bot for automating changes across repositories.
Changes produced by the roomba/junit5 check.
To enable or disable this check, please contact the maintainers of Excavator.