Handle error output of docker commands#188
Open
hakkanicko wants to merge 4 commits intopalantir:masterfrom
Open
Handle error output of docker commands#188hakkanicko wants to merge 4 commits intopalantir:masterfrom
hakkanicko wants to merge 4 commits intopalantir:masterfrom
Conversation
added 2 commits
March 29, 2017 16:45
Update Command to handle this new ErrorHandler
Member
|
Thanks for your interest in palantir/docker-compose-rule, @hakkanicko! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
|
@hakkanicko Do you think you'll be able to move on and sign the agreement so others can gain from your contribution? 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than mix stdout and stderr of docker commands, I suggest a way to handle stderr separately.
See #187