Include .git for revision SHA at docker build time #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corviday
approved these changes
Aug 1, 2025
Contributor
corviday
left a comment
corviday
left a comment
There was a problem hiding this comment.
Nice detective work! Makes sense, and I have verified that the demo now displays a version.
|
I think that you include .git at any point it'll be included as a layer within the image and therefore you won't get the space saving benefit of not including it in the first place. Doesn't look like this effects image size too much however: historic image sizes and where this image's size comes from Though 500MB images are a little concerning in themselves, we'll have to take that into another issue 🛩️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Versions now show up correctly:
PCIC Data Portal version 4.4.1 (i242.fix.version.filling:fb956e)Demo on orca-pdp:
https://beehive.pacificclimate.org/orca-pdp/portal/gridded_observations/map/
Resolves #242