Update local test setup to python 3 #258
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rod-glover
reviewed
Oct 25, 2021
docker/local-run/Dockerfile
Outdated
| @@ -1,4 +1,4 @@ | |||
| FROM pcic/pdp-base-minimal:1.0.0 | |||
| FROM pdp-python3 | |||
Contributor
There was a problem hiding this comment.
pdp-base-minimal:pdp-python3
This makes the image that the docker container uses.
rod-glover
reviewed
Oct 25, 2021
rod-glover
reviewed
Oct 25, 2021
rod-glover
reviewed
Oct 25, 2021
Contributor
Author
|
Thank you for the help, I was confused about which commands were building on an existing image, creating a new image, or naming an image. |
Contributor
Author
|
I am still seeing some filepaths in traceroutes that indicate python 2.7 is being used. I updated all uses of "pip" in the entrypoint files to "pip3" but I'm not sure if that actually did anything - it didn't fix the problem. |
Contributor
Author
|
Redundant with #282 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the development setup to python 3.
This PR isn't for merging, it's just a nice way to compare changes made to the files.