-
Notifications
You must be signed in to change notification settings - Fork 1
Release/v1.3.0 #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Release/v1.3.0 #57
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3d9be6b
Remove snapshot
p14n a0b7010
Correct buildfile
p14n 56e8444
Correct buildfile
p14n 883821e
Javadoc and buildfile fixes
p14n 3202652
Set version 1.3.0
p14n cc908fd
Change publish structure
p14n 061fb95
Remove snapshot version
p14n f35784f
Prep next version
p14n File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| plugins { | ||
| id 'com.vanniktech.maven.publish' version '0.34.0' apply false | ||
| } | ||
|
|
||
| subprojects { | ||
|
|
||
| apply plugin: 'java-library' | ||
| apply plugin: 'com.vanniktech.maven.publish' | ||
|
|
||
| group = 'test' | ||
| version = '1.0' | ||
|
|
||
| mavenPublishing { | ||
| publishToMavenCentral(true) | ||
| signAllPublications() | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,6 @@ | ||
| rootProject.name = 'postevent' | ||
| include 'core', 'debezium', 'grpc', 'vertx', 'app' | ||
| include 'core', 'debezium', 'grpc', 'vertx' | ||
| project(':core').name = 'postevent-core' | ||
| project(':debezium').name = 'postevent-debezium' | ||
| project(':grpc').name = 'postevent-grpc' | ||
| project(':vertx').name = 'postevent-vertx' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,28 +15,53 @@ | |
| import java.util.List; | ||
| import java.util.Set; | ||
|
|
||
| /** | ||
| * Vert.x-based consumer server that provides event consumption capabilities | ||
| * using the EventBus for communication and coordination. | ||
| * | ||
| * <p> | ||
| * This server sets up the necessary infrastructure for event processing | ||
| * including database setup, message brokers, and catchup services. | ||
| * </p> | ||
| */ | ||
| public class VertxConsumerServer implements AutoCloseable { | ||
| private static final Logger logger = LoggerFactory.getLogger(VertxConsumerServer.class); | ||
|
|
||
| private DataSource ds; | ||
| //private ConfigData cfg; | ||
| private final DataSource ds; | ||
| private List<AutoCloseable> closeables; | ||
| private AsyncExecutor asyncExecutor; | ||
| private final AsyncExecutor asyncExecutor; | ||
| OpenTelemetry ot; | ||
|
|
||
| /** | ||
| * Creates a new VertxConsumerServer. | ||
| * | ||
| * @param ds The DataSource for database operations | ||
| * @param asyncExecutor The async executor for handling operations | ||
| * @param ot The OpenTelemetry instance for observability | ||
| */ | ||
| public VertxConsumerServer(DataSource ds, AsyncExecutor asyncExecutor, OpenTelemetry ot) { | ||
| this.ds = ds; | ||
| this.asyncExecutor = asyncExecutor; | ||
| this.ot = ot; | ||
| } | ||
|
|
||
| public void start(EventBus eb, EventBusMessageBroker mb, Set<String> topics) throws IOException, InterruptedException { | ||
| /** | ||
| * Starts the consumer server with the specified configuration. | ||
| * | ||
| * @param eb The Vert.x EventBus to use for communication | ||
| * @param mb The EventBus message broker for event handling | ||
| * @param topics The set of topics to handle | ||
| * @throws IOException If database setup fails | ||
| * @throws InterruptedException If the operation is interrupted | ||
| */ | ||
| public void start(EventBus eb, EventBusMessageBroker mb, Set<String> topics) | ||
| throws IOException, InterruptedException { | ||
| logger.atInfo().log("Starting consumer server"); | ||
|
|
||
| var db = new DatabaseSetup(ds); | ||
| db.setupServer(topics); | ||
| var catchupServer = new CatchupServer(ds); | ||
| var catchupService = new EventBusCatchupService(catchupServer,eb,topics,this.asyncExecutor); | ||
| var catchupService = new EventBusCatchupService(catchupServer, eb, topics, this.asyncExecutor); | ||
|
|
||
| closeables = List.of(catchupService, mb, asyncExecutor); | ||
| System.out.println("🌐 Vert.x EventBus server started"); | ||
|
|
@@ -45,11 +70,11 @@ public void start(EventBus eb, EventBusMessageBroker mb, Set<String> topics) thr | |
|
|
||
| @Override | ||
| public void close() { | ||
| if(closeables != null){ | ||
| for(var c : closeables){ | ||
| if (closeables != null) { | ||
| for (var c : closeables) { | ||
| try { | ||
| c.close(); | ||
| } catch (Exception e){ | ||
| } catch (Exception e) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. issue (bug_risk): Swallowing exceptions in close() may hide resource cleanup issues. Logging exceptions in the catch block will help identify resource leaks and improve reliability. |
||
|
|
||
| } | ||
| } | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Replace System.out.println with structured logging.
Switch to logger.atInfo().log(...) for improved consistency and observability.