Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pull request, I've implemented a minimal version of a multi-asset shielded pool based on the latest Nova code. The modifications can be divided into three parts: Circom circuits, smart contracts, and JavaScript test code.
Circom circuits:
I've added one public input
publicAssetand one private inputassetto the Circom circuits. Theassetinput has been included in the UTXO structure, so it's constrained by the Poseidon hash in bothinCommitmentHasherandoutCommitmentHasher. This ensures that the asset type is checked when using a UTXO. To simplify the circuit logic, I've set a constraint that one transaction can only contain one asset type, meaning all UTXOs in a transaction must have the same asset type.The
publicAssetinput is used for on-chain transfers. Specifically, whenextAmountis not zero, there will be an on-chain transfer for the token, and the asset type cannot be kept private. In this case, we must ensure thatpublicAssetequalsassetto maintain security. I've chosen0as the default value forpublicAsset. WhenpublicAssetis0, no on-chain transfer occurs, and there's no constraint betweenpublicAssetandasset.Smart contracts:
The smart contracts now support different types of tokens.
Conclusion:
I believe that with these modifications, all tokens can share the same privacy level for internal shielded transfers.