chore: sync lora implementation with upstream #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently using our own LoRA implementation, while miles will rely on PEFT as soon as their implementation is merged into main. Thus we should migrate to PEFT. Also, we should match the code structure of the two PRs in order to avoid merge conflicts as much as possible down the line.
Miles LoRA PRs:
radixark#377
radixark#326
Changes