sort correctly when subsection appears before file#57
Open
andreaswachowski wants to merge 1 commit intoozum:masterfrom
Open
sort correctly when subsection appears before file#57andreaswachowski wants to merge 1 commit intoozum:masterfrom
andreaswachowski wants to merge 1 commit intoozum:masterfrom
Conversation
andreaswachowski
force-pushed
the
fix-ordering
branch
from
7c90f48 to
1f13d9d
Compare
andreaswachowski
force-pushed
the
fix-ordering
branch
from
1f13d9d to
be95053
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When comparing the title when the child is an object, the associated folder-structure is ignored, which leads to weird results. This fix will recursively look for a string-child, thus preserving the folder structure in the comparison and maintaining the desired sort order.
Try the test case without the fix: The main sections will switch places, so that section 02 appears before section 01.
This only happens, however, with a subsection (here
01-section/a) that is alphabetically before the second child (here01-section/b). When the folderawere renamed toc, the original logic works as expected.