Skip to content

chore: go1.26#379

Open
dkharms wants to merge 2 commits intomainfrom
0-go-126-bump
Open

chore: go1.26#379
dkharms wants to merge 2 commits intomainfrom
0-go-126-bump

Conversation

@dkharms
Copy link
Member

@dkharms dkharms commented Mar 18, 2026

Description

Finally, bump Golang version to 1.26
Seems like there is a small performance degradation (around 1-3% of increased CPU usage).


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

If you have used LLM/AI assistance please provide model name and full prompt:

Model: {{model-name}}
Prompt: {{prompt}}

@dkharms dkharms force-pushed the 0-go-126-bump branch 2 times, most recently from 1736b86 to 8e225f0 Compare March 18, 2026 11:31
@ozontech ozontech deleted a comment from seqbenchbot Mar 18, 2026
@ozontech ozontech deleted a comment from seqbenchbot Mar 18, 2026
@dkharms
Copy link
Member Author

dkharms commented Mar 18, 2026

@seqbenchbot up main bulk

@seqbenchbot
Copy link

seqbenchbot commented Mar 18, 2026

Nice, @dkharms <(-^,^-)=b!

Your request was successfully served.
Identificator for your ongoing benchmark - c91cbd68.

Here is a list of helpful links:

  • Take a look at Grafana dashboard;
  • Live-tailing logs are also available;

Have a great time!

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.21%. Comparing base (7fa2c2e) to head (f42b5ab).

Files with missing lines Patch % Lines
proxy/search/ingestor.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #379      +/-   ##
==========================================
+ Coverage   71.18%   71.21%   +0.03%     
==========================================
  Files         206      206              
  Lines       15145    15145              
==========================================
+ Hits        10781    10786       +5     
+ Misses       3571     3567       -4     
+ Partials      793      792       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dkharms
Copy link
Member Author

dkharms commented Mar 18, 2026

@seqbenchbot down c91cbd68

@seqbenchbot
Copy link

seqbenchbot commented Mar 18, 2026

Nice, @dkharms <(-^,^-)=b!

The benchmark with identificator c91cbd68 was finished.
I've prepared a summary for you. Click on Show summary button to see it:

Show summary
Query Type mean (ms) stddev (ms) p(50) (ms) p(95) (ms) p(99) (ms) iterations
base comp diff base comp diff base comp diff base comp diff base comp diff base comp diff
bulk
warm 64.11 69.80 +8.87% 24.83 33.36 +34.31% 57.00 58.00 +1.75% 115.00 141.00 +22.61% 156.00 194.00 +24.36% 12521.00 12243.00 -2.22%

Have a great time!

@dkharms
Copy link
Member Author

dkharms commented Mar 18, 2026

@seqbenchbot up main bulk

@seqbenchbot
Copy link

seqbenchbot commented Mar 18, 2026

Nice, @dkharms <(-^,^-)=b!

Your request was successfully served.
Identificator for your ongoing benchmark - 036993ee.

Here is a list of helpful links:

  • Take a look at Grafana dashboard;
  • Live-tailing logs are also available;

Have a great time!

@dkharms
Copy link
Member Author

dkharms commented Mar 18, 2026

@seqbenchbot down 036993ee

@seqbenchbot
Copy link

seqbenchbot commented Mar 18, 2026

Nice, @dkharms <(-^,^-)=b!

The benchmark with identificator 036993ee was finished.
I've prepared a summary for you. Click on Show summary button to see it:

Show summary
Query Type mean (ms) stddev (ms) p(50) (ms) p(95) (ms) p(99) (ms) iterations
base comp diff base comp diff base comp diff base comp diff base comp diff base comp diff
bulk
warm 51.27 51.61 +0.67% 14.31 14.77 +3.21% 48.00 48.00 0.00% 79.00 80.00 +1.27% 99.00 102.00 +3.03% 36257.00 36249.00 -0.02%

Have a great time!

@ozontech ozontech deleted a comment from seqbenchbot Mar 18, 2026
@dkharms
Copy link
Member Author

dkharms commented Mar 18, 2026

@seqbenchbot up main mixed

@seqbenchbot
Copy link

seqbenchbot commented Mar 18, 2026

Nice, @dkharms <(-^,^-)=b!

Your request was successfully served.
Identificator for your ongoing benchmark - f0c2846c.

Here is a list of helpful links:

  • Take a look at Grafana dashboard;
  • Live-tailing logs are also available;

Have a great time!

@dkharms
Copy link
Member Author

dkharms commented Mar 18, 2026

@seqbenchbot down f0c2846c

@seqbenchbot
Copy link

seqbenchbot commented Mar 18, 2026

Nice, @dkharms <(-^,^-)=b!

The benchmark with identificator f0c2846c was finished.
I've prepared a summary for you. Click on Show summary button to see it:

Show summary
Query Type mean (ms) stddev (ms) p(50) (ms) p(95) (ms) p(99) (ms) iterations
base comp diff base comp diff base comp diff base comp diff base comp diff base comp diff
bulk
warm 50.25 49.95 -0.59% 13.68 14.26 +4.22% 47.00 46.00 -2.13% 77.00 78.00 +1.30% 98.00 100.00 +2.04% 7657.00 7629.00 -0.37%
service:payment-backend-eu
AND k8s_namespace:prod
AND level:[0 to 3]
AND (
    message:'failed'
    OR message:'timeout'
)
warm 46.57 48.38 +3.88% 15.25 15.43 +1.16% 42.00 44.00 +4.76% 83.50 87.00 +4.19% 110.00 109.50 -0.45% 988.00 980.00 -0.81%

Have a great time!

@github-actions
Copy link
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
And/size=1000-4 7fa2c2 48c9a1
4.70 ns/op 5.50 ns/op 1.17 🔴
And/size=10000-4 7fa2c2 48c9a1
4.68 ns/op 5.49 ns/op 1.17 🔴
And/size=1000000-4 7fa2c2 48c9a1
4.41 ns/op 5.28 ns/op 1.20 🔴
AndTree/size=1000-4 7fa2c2 48c9a1
4.14 ns/op 5.14 ns/op 1.24 🔴
AndTree/size=10000-4 7fa2c2 48c9a1
4.17 ns/op 5.11 ns/op 1.23 🔴
AndTree/size=1000000-4 7fa2c2 48c9a1
4.53 ns/op 5.63 ns/op 1.24 🔴
Complex/size=1000-4 7fa2c2 48c9a1
5.02 ns/op 5.58 ns/op 1.11 🔴
Complex/size=1000000-4 7fa2c2 48c9a1
5.52 ns/op 6.16 ns/op 1.12 🔴
FindSequence_Random/medium-4 7fa2c2 48c9a1
12429.58 MB/s 10180.83 MB/s 0.82 🔴
FindSequence_Random/small-4 7fa2c2 48c9a1
5596.51 MB/s 4733.71 MB/s 0.85 🔴
47.26 ns/op 54.08 ns/op 1.14 🔴
NAnd/size=1000-4 7fa2c2 48c9a1
4.52 ns/op 5.26 ns/op 1.16 🔴
NAnd/size=10000-4 7fa2c2 48c9a1
4.52 ns/op 5.26 ns/op 1.16 🔴
NAnd/size=1000000-4 7fa2c2 48c9a1
4.62 ns/op 5.34 ns/op 1.15 🔴
Not/size=1000-4 7fa2c2 48c9a1
4.68 ns/op 5.44 ns/op 1.16 🔴
Not/size=10000-4 7fa2c2 48c9a1
4.68 ns/op 5.45 ns/op 1.16 🔴
Not/size=1000000-4 7fa2c2 48c9a1
4.83 ns/op 5.68 ns/op 1.17 🔴
NotEmpty/size=1000-4 7fa2c2 48c9a1
4.70 ns/op 5.46 ns/op 1.16 🔴
NotEmpty/size=10000-4 7fa2c2 48c9a1
4.70 ns/op 5.46 ns/op 1.16 🔴
NotEmpty/size=1000000-4 7fa2c2 48c9a1
4.72 ns/op 5.48 ns/op 1.16 🔴
Or/size=1000-4 7fa2c2 48c9a1
4.46 ns/op 5.24 ns/op 1.18 🔴
Or/size=10000-4 7fa2c2 48c9a1
4.47 ns/op 5.26 ns/op 1.18 🔴
Or/size=1000000-4 7fa2c2 48c9a1
4.54 ns/op 5.35 ns/op 1.18 🔴
OrTree/size=1000-4 7fa2c2 48c9a1
4.46 ns/op 5.25 ns/op 1.18 🔴
OrTree/size=10000-4 7fa2c2 48c9a1
4.52 ns/op 5.27 ns/op 1.17 🔴
OrTree/size=1000000-4 7fa2c2 48c9a1
5.51 ns/op 6.66 ns/op 1.21 🔴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants