Skip to content

fix: stabilize FindSequence microbench#378

Open
cheb0 wants to merge 1 commit intomainfrom
0-stabilize-find-seq-microbench
Open

fix: stabilize FindSequence microbench#378
cheb0 wants to merge 1 commit intomainfrom
0-stabilize-find-seq-microbench

Conversation

@cheb0
Copy link
Member

@cheb0 cheb0 commented Mar 18, 2026

Description

Same, as before - just use same random data across runs.

main branch:
20.68 ns/op
28.29 ns/op
34.91 ns/op
29.05 ns/op

now:
21.00 ns/op
20.95 ns/op
20.67 ns/op
20.69 ns/op

It also means the data will always be same.

The alternative solution would be to generate 1000+ random haystacks and needles and run across all of them. That would also possibly make results more stable as well. However, I would leave it to someone who wants to change the function logic itself.


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.33%. Comparing base (03b2938) to head (05b1154).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
- Coverage   71.33%   71.33%   -0.01%     
==========================================
  Files         206      206              
  Lines       15140    15145       +5     
==========================================
+ Hits        10800    10803       +3     
- Misses       3553     3555       +2     
  Partials      787      787              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
FindSequence_Random/medium-4 7fa2c2 78c9a9
12429.58 MB/s 9823.45 MB/s 0.79 🔴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants