Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #378 +/- ##
==========================================
- Coverage 71.33% 71.33% -0.01%
==========================================
Files 206 206
Lines 15140 15145 +5
==========================================
+ Hits 10800 10803 +3
- Misses 3553 3555 +2
Partials 787 787 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
🔴 Performance DegradationSome benchmarks have degraded compared to the previous run. Show table
|
dkharms
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Same, as before - just use same random data across runs.
main branch:
20.68 ns/op
28.29 ns/op
34.91 ns/op
29.05 ns/op
now:
21.00 ns/op
20.95 ns/op
20.67 ns/op
20.69 ns/op
It also means the data will always be same.
The alternative solution would be to generate 1000+ random haystacks and needles and run across all of them. That would also possibly make results more stable as well. However, I would leave it to someone who wants to change the function logic itself.