Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature/auditoria victorialogs #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Feature/auditoria victorialogs #54
Changes from all commits
5fb32f32d14634b23f45ca629d9d2433a28547e80ad910da9fce2702180a35c1ad422b4947d1a8d66ba97ea15597d23f59a360aa656a1e8e4fd2ed72a78630b5caabc27ab3a73e1a5f04da30e3b42d302File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
attributesare spread intostructuredDatawithout normalization. If a consumer passes a non-JSON-serializable value (e.g. BigInt/symbol) inattributes,JSON.stringifywill throw; the catch block only replacesbodyand then stringifies again, which will still throw for the same bad attribute. Consider normalizing/sanitizingattributes(and/orLogger.globalAttributes) before spreading, or in the catch block fall back to a minimal guaranteed-serializable payload (e.g. omit attributes/context when serialization fails).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change removes the previously emitted
datafield (which was marked deprecated). Even if deprecated, removing it is a breaking change for any consumers still reading it. Consider keepingdataas an alias ofbodyfor one more release (or explicitly document the breaking change / bump major version).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New behavior adds per-instance
attributesand global attributes into JSON output, but the existing JSON formatter tests don’t assert these fields. Add tests covering: (1) instanceattributespassed tocreateLoggerappear on the root of the JSON payload, and (2)Logger.setGlobalAttributes()adds fields without breaking logs when unset.Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.