Skip to content
This repository was archived by the owner on Dec 5, 2019. It is now read-only.

Conversation

@paladox
Copy link
Contributor

@paladox paladox commented Oct 26, 2015

I manually did the update with out any software telling me where errors were.

So if you run php code sniffer there may be more warnings but I fixed the spaces and curly braces.

I manually did the update with out any software telling me where errors were.

So if you run php code sniffer there may be more warnings but I fixed the spaces and curly braces.
@PhrozenByte
Copy link
Contributor

You want to change from PSR-0 to PSR-4 autoloaders (#263), but don't want to follow PSR-1 and PSR-2 code styling? What's the advantage of another non-standard code styling? Your proposal is neither better nor worse oyejorges code styling, except for the fact that this is oyejorges project and he's the only person entitled to choose the code styling he personally prefers 😉

@paladox
Copy link
Contributor Author

paladox commented Oct 26, 2015

Hi I carnt find anything on psr-1 or psr-2 I can only see psr-4 and psr-0 in google search results.

@PhrozenByte
Copy link
Contributor

http://www.php-fig.org/psr/psr-1/
http://www.php-fig.org/psr/psr-2/

Code styling is a completely subjective thing, before doing this you should wait for @oyejorge's feedback if he actually wants this.

@paladox
Copy link
Contributor Author

paladox commented Oct 26, 2015

Well the closest thing to psr-0 is psr-4

Please see http://www.php-fig.org/psr/psr-0/ which recommends using psr-4.

@PhrozenByte
Copy link
Contributor

You're probably mixing this up with #263 😄
PSR-0 and PSR-4 are about autoloading (your PR #263), PSR-1 and PSR-2 about code styling (this PR). I'm not talking about autoloading, I'm talking about this PR (code styling).

@paladox
Copy link
Contributor Author

paladox commented Oct 26, 2015

Oh. So psr-1 and psr-2 are code styling didn't know that sorry. I am not sure what to do to follow that. Is there any composer packages that follow there coding standards.

@PhrozenByte
Copy link
Contributor

Exactly. Just read the PSR-1 and PSR-2 docs, they already contain examples. As said, before doing this you should wait for @oyejorge's feedback.

oyejorge added a commit that referenced this pull request Dec 30, 2015
@oyejorge oyejorge merged commit ff0e74f into oyejorge:master Dec 30, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants