Hide create button for anonymous users #180
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here are the the conditions for the showing/hiding the create button: - Hide create button if user is not logged in - Hide create button if user is logged in but not an oxide employee - Always show create button in dev mode (no change) - Show the the create button if user is logged in and an oxide employee
|
@oblakeerickson is attempting to deploy a commit to the Oxide Computer Company Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the the conditions for the showing/hiding the create button:
Added
aria-label="Create new RFD"for accessibility and for future testing.I didn't add any tests because it looks like locally the tests only run in dev mode and so the button would be always visible. Looks like we could add some tests to run in CI and they will run in production mode, but we would have to skip them locally. But even if we ran the production tests in CI we don't have any existing logged-in test infrastructure.
Resolves: #64